Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(disrupt_remove_node_then_add_node): call nodetool removenode as long_running #9518

Merged
merged 1 commit into from
Dec 10, 2024
Merged

fix(disrupt_remove_node_then_add_node): call nodetool removenode as long_running #9518

merged 1 commit into from
Dec 10, 2024

Conversation

fruch
Copy link
Contributor

@fruch fruch commented Dec 9, 2024 •
edited
Loading

since this command can take long, and ssh connection might get interrupted we should use the long_running=True option, so the command would be executed on the node, and retrieve the output when it finish.

Fixes: #9494

Testing

  • [ ]

PR pre-checks (self review)

  • I added the relevant backport labels
  • I didn't leave commented-out/debugging code

Reminders

  • Add New configuration option and document them (in sdcm/sct_config.py)
  • Add unit tests to cover my changes (under unit-test/ folder)
  • Update the Readme/doc folder relevant to this change (if needed)

@fruch
fix(disrupt_remove_node_then_add_node): call nodetool removenode as…
e24f159 
… long_running

since this command can take long, and ssh connection might get interuppted
we should use the `long_running=True` option, so the command
would be exceuted on the node, and retrive the output when it
finish.

Fixes: scylladb#9494
@fruch fruch added backport/2024.2 Need backport to 2024.2 backport/6.1 Need backport to 6.1 backport/6.2 labels Dec 9, 2024
@fruch fruch requested a review from a team December 9, 2024 23:51
@fruch fruch added backport/2024.1 Need backport to 2024.1 tests/longevity-tier1 labels Dec 9, 2024
vponomaryov
vponomaryov approved these changes Dec 10, 2024
View reviewed changes
Copy link
Contributor

@vponomaryov vponomaryov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fruch fruch merged commit ecc2c7e into scylladb:master Dec 10, 2024
13 checks passed
This was referenced Dec 10, 2024
Merged
Merged
Merged
Merged
@scylladbbot scylladbbot added backport/6.2-done backport/6.1-done Commit backported to 6.1 backport/2024.2-done Commit backported to 2024.2 and removed backport/6.2 backport/6.1 Need backport to 6.1 backport/2024.2 Need backport to 2024.2 labels Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vponomaryov vponomaryov vponomaryov approved these changes

Assignees

@fruch fruch

Labels
backport/6.1-done Commit backported to 6.1 backport/6.2-done backport/2024.1 Need backport to 2024.1 backport/2024.2-done Commit backported to 2024.2 promoted-to-master tests/longevity-tier1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

nodetool removenode should call with long_running=True
3 participants
@fruch @vponomaryov @scylladbbot